Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor use of app instance #4478

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Refactor use of app instance #4478

merged 2 commits into from
Jan 20, 2025
+86 −79

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jan 17, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added the skip-changelog Can be missed from the changelog. label Jan 17, 2025
@ssbarnea ssbarnea changed the title Make uv use constraints like pip Correct minimal requirements Jan 17, 2025
@ssbarnea ssbarnea added bug and removed skip-changelog Can be missed from the changelog. labels Jan 17, 2025
@ssbarnea ssbarnea marked this pull request as ready for review January 17, 2025 13:22
@ssbarnea ssbarnea requested a review from a team as a code owner January 17, 2025 13:22
@ssbarnea
Correct minimal requirements
0487cfd 
- Ensure that our lower requirements can be used
- Make uv use constraints like pip (failed to for some time)
- Fix broken test logic related to vault password
This was referenced Jan 19, 2025
Merged
Closed
@ssbarnea ssbarnea changed the title Correct minimal requirements Refactor use of app instance Jan 19, 2025
abhikdps
abhikdps approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@abhikdps abhikdps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhikdps abhikdps merged commit 4eaedaa into main Jan 20, 2025
29 checks passed
@abhikdps abhikdps deleted the chore/uv branch January 20, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhikdps abhikdps abhikdps approved these changes

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @abhikdps